Re: [PATCH v3 07/12] video: fbdev: intelfb: use const pointer for fb_ops
From: Daniel Vetter <hidden>
Date: 2019-12-03 17:09:43
Also in:
dri-devel, intel-gfx
On Tue, Dec 03, 2019 at 06:38:49PM +0200, Jani Nikula wrote:
quoted hunk ↗ jump to hunk
Use const for fb_ops to let us make the fbops struct const in the future. Cc: linux-fbdev@vger.kernel.org Signed-off-by: Jani Nikula <redacted> --- drivers/video/fbdev/intelfb/intelfb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/video/fbdev/intelfb/intelfb.h b/drivers/video/fbdev/intelfb/intelfb.h index b54db05f028d..5de703902a21 100644 --- a/drivers/video/fbdev/intelfb/intelfb.h +++ b/drivers/video/fbdev/intelfb/intelfb.h@@ -273,7 +273,7 @@ struct intelfb_vsync { struct intelfb_info { struct fb_info *info; - struct fb_ops *fbops; + const struct fb_ops *fbops;
I think aside from a lone assignment in intelfb_pci_register this is entirely unused. But I also think resistance is futile so Reviewed-by: Daniel Vetter <redacted>
struct pci_dev *pdev; struct intelfb_hwstate save_state; -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch