Thread (33 messages) 33 messages, 8 authors, 2019-12-08

Re: [PATCH v2 14/14] auxdisplay: constify fb ops

From: robin <robin@protonic.nl>
Date: 2019-12-02 07:37:02
Also in: dri-devel, intel-gfx

On 2019-11-29 11:29, Jani Nikula wrote:
quoted hunk ↗ jump to hunk
Now that the fbops member of struct fb_info is const, we can start
making the ops const as well.

Cc: Miguel Ojeda Sandonis <redacted>
Cc: Robin van der Gracht <robin@protonic.nl>
Signed-off-by: Jani Nikula <redacted>
---
 drivers/auxdisplay/cfag12864bfb.c | 2 +-
 drivers/auxdisplay/ht16k33.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/auxdisplay/cfag12864bfb.c
b/drivers/auxdisplay/cfag12864bfb.c
index 4074886b7bc8..2002291ab338 100644
--- a/drivers/auxdisplay/cfag12864bfb.c
+++ b/drivers/auxdisplay/cfag12864bfb.c
@@ -57,7 +57,7 @@ static int cfag12864bfb_mmap(struct fb_info *info,
struct vm_area_struct *vma)
 	return vm_map_pages_zero(vma, &pages, 1);
 }

-static struct fb_ops cfag12864bfb_ops = {
+static const struct fb_ops cfag12864bfb_ops = {
 	.owner = THIS_MODULE,
 	.fb_read = fb_sys_read,
 	.fb_write = fb_sys_write,
diff --git a/drivers/auxdisplay/ht16k33.c 
b/drivers/auxdisplay/ht16k33.c
index a2fcde582e2a..d951d54b26f5 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -228,7 +228,7 @@ static int ht16k33_mmap(struct fb_info *info,
struct vm_area_struct *vma)
 	return vm_map_pages_zero(vma, &pages, 1);
 }

-static struct fb_ops ht16k33_fb_ops = {
+static const struct fb_ops ht16k33_fb_ops = {
 	.owner = THIS_MODULE,
 	.fb_read = fb_sys_read,
 	.fb_write = fb_sys_write,
Acked-by: Robin van der Gracht <robin@protonic.nl>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help