Re: [Intel-gfx] [PATCH 03/13] video: smscufx: don't restore fb_mmap after deferred IO cleanup

From
Daniel Vetter <hidden>
Date
2019-11-27 18:20:28
Also in
dri-devel, intel-gfx
Reply to
Jani Nikula, 2019-11-27
On Wed, Nov 27, 2019 at 06:31:59PM +0200, Jani Nikula wrote:
quoted hunk ↗ jump to hunk
Deferred IO now preserves the fb_ops.

Cc: Steve Glendinning <steve.glendinning@shawell.net>
Cc: <redacted>
Signed-off-by: Jani Nikula <redacted>
---
 drivers/video/fbdev/smscufx.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c
index 0e0f5bbfc5ef..e362d7da87fc 100644
--- a/drivers/video/fbdev/smscufx.c
+++ b/drivers/video/fbdev/smscufx.c
@@ -1170,7 +1170,6 @@ static int ufx_ops_release(struct fb_info *info, int user)
 		fb_deferred_io_cleanup(info);
 		kfree(info->fbdefio);
 		info->fbdefio = NULL;
-		info->fbops->fb_mmap = ufx_ops_mmap;
Also totally pointless to restore this here, since if you have indeed
loaded the driver twice shit has hit the fan already. I guess that was for
the module option .... wtf.

Reviewed-by: Daniel Vetter <redacted>
 	}
 
 	pr_debug("released /dev/fb%d user=%d count=%d",
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Thread (36 messages) 36 messages, 6 authors, last reply 2019-11-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help