Thread (2 messages) 2 messages, 2 authors, 2020-01-15
STALE2449d

[PATCH] video: fbdev: arcfb: add missed free_irq

From: Chuhong Yuan <hidden>
Date: 2019-11-16 15:44:34
Also in: dri-devel, lkml
Subsystem: arc framebuffer driver, framebuffer layer, the rest · Maintainers: Jaya Kumar, Helge Deller, Linus Torvalds

The driver forgets to free irq in remove which is requested in
probe.
Add the missed call to fix it.

Signed-off-by: Chuhong Yuan <redacted>
---
 drivers/video/fbdev/arcfb.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/video/fbdev/arcfb.c b/drivers/video/fbdev/arcfb.c
index a48741aab240..7aed01f001a4 100644
--- a/drivers/video/fbdev/arcfb.c
+++ b/drivers/video/fbdev/arcfb.c
@@ -590,8 +590,11 @@ static int arcfb_probe(struct platform_device *dev)
 static int arcfb_remove(struct platform_device *dev)
 {
 	struct fb_info *info = platform_get_drvdata(dev);
+	struct arcfb_par *par = info->par;
 
 	if (info) {
+		if (irq)
+			free_irq(par->irq, info);
 		unregister_framebuffer(info);
 		vfree((void __force *)info->screen_base);
 		framebuffer_release(info);
-- 
2.24.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help