Re: [PATCH] fbdev: potential information leak in do_fb_ioctl()

From
Eric W. Biederman <hidden>
Date
2019-10-31 22:12:26
Also in
dri-devel, kernel-janitors, lkml
Joe Perches [off-list ref] writes:
On Wed, 2019-10-30 at 21:12 +0100, Andrea Righi wrote:
quoted
Then memset() + memcpy() is probably the best option,
since copying all those fields one by one looks quite ugly to me...
A memset of an automatic before a memcpy to the same
automatic is unnecessary.
You still need to guarantee that all of the holes in the
structure you are copying are initialized before you copy it.

Otherwise you are just changing which unitialized memory that
is being copied to userspace.

Which is my concern with your very simple suggestion.

Eric
Thread (1 message) 1 message, 1 author, last reply 2019-10-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help