Thread (6 messages) 6 messages, 4 authors, 2020-01-03

Re: [PATCH] omapfb: reduce stack usage

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2019-10-19 09:12:02
Also in: dri-devel, linux-omap, lkml

On Fri, Oct 18, 2019 at 06:19:15PM -0700, Joe Perches wrote:
On Fri, 2019-10-18 at 23:30 +0100, Sudip Mukherjee wrote:
quoted
On Fri, Oct 18, 2019 at 07:27:28PM +0200, Ladislav Michl wrote:
quoted
On Fri, Oct 18, 2019 at 05:30:04PM +0100, Sudip Mukherjee wrote:
quoted
The build of xtensa allmodconfig is giving a warning of:
In function 'dsi_dump_dsidev_irqs':
warning: the frame size of 1120 bytes is larger than 1024 bytes
<snip>
Without your patch:

$ objdump -x drivers/video/fbdev/omap2/omapfb/dss/dsi.o | grep dsi_dump_dsidev_irqs
00000d20 l     F .text	0000061c dsi_dump_dsidev_irqs

With your patch:

$ objdump -x drivers/video/fbdev/omap2/omapfb/dss/dsi.o | grep dsi_dump_dsidev_irqs
00000d20 l     F .text	00000638 dsi_dump_dsidev_irqs
I did objdump -d and then compared where it started and where it ended.

But, in anycase, this driver is framebuffer driver for omap2 and in
reality, can only be used on arm platform and when I build the driver
with arm compiler I am not getting this warning. This is not a valid
concern, please reject this patch.

--
Regards
Sudip
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help