Re: [PATCH] video: backlight: tosa_lcd: drop check because i2c_unregister_device() is NULL safe
From: Daniel Thompson <hidden>
Date: 2019-08-20 16:32:35
Also in:
dri-devel, linux-i2c, lkml
On Tue, Aug 20, 2019 at 05:34:39PM +0200, Wolfram Sang wrote:
No need to check the argument of i2c_unregister_device() because the function itself does it. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Daniel Thompson <redacted>
quoted hunk ↗ jump to hunk
--- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/video/backlight/tosa_lcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/video/backlight/tosa_lcd.c b/drivers/video/backlight/tosa_lcd.c index 65cb7578776f..29af8e27b6e5 100644 --- a/drivers/video/backlight/tosa_lcd.c +++ b/drivers/video/backlight/tosa_lcd.c@@ -222,8 +222,7 @@ static int tosa_lcd_remove(struct spi_device *spi) { struct tosa_lcd_data *data = spi_get_drvdata(spi); - if (data->i2c) - i2c_unregister_device(data->i2c); + i2c_unregister_device(data->i2c); tosa_lcd_tg_off(data);-- 2.20.1