Thread (11 messages) 11 messages, 5 authors, 2019-08-05

Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support

From: Lee Jones <hidden>
Date: 2019-07-25 15:06:44
Also in: dri-devel

On Thu, 25 Jul 2019, Daniel Vetter wrote:
On Thu, Jul 25, 2019 at 04:32:24PM +0200, Sam Ravnborg wrote:
quoted
There was no users left - so drop the code to support EARLY_FB_BLANK.
This patch removes the support in backlight,
and drop the notifier in fbmem.

That EARLY_FB_BLANK is not used can be verified that no driver set any of:

    lcd_ops.early_set_power()
    lcd_ops.r_early_set_power()

Noticed while browsing backlight code for other reasons.
Ah I didn't grep hard enough, I didn't realize that no one sets the
lcd_ops->(r_)early_set_power hooks. Nice find!

Reviewed-by: Daniel Vetter <redacted>
quoted
Signed-off-by: Sam Ravnborg <redacted>
Cc: Lee Jones <redacted>
Cc: Daniel Thompson <redacted>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Daniel Vetter <redacted>
Cc: Sam Ravnborg <redacted>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Peter Rosin <redacted>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
---

Build tested with various architectures, configs.

Lee, Daniel - OK to commit to drm-misc-next where fbdev stuff is
maintained today?
backlight is separate from fbdev in Lee's own tree, not in drm-misc. I
think at least.
That's correct.  We'll sort that once we have all the Acks.
quoted
 drivers/video/backlight/lcd.c    |  8 --------
 drivers/video/fbdev/core/fbmem.c | 12 +-----------
 include/linux/fb.h               |  4 ----
 include/linux/lcd.h              | 10 ----------
 4 files changed, 1 insertion(+), 33 deletions(-)
-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help