pon., 22 lip 2019 o 18:09 Andy Shevchenko
[off-list ref] napisał(a):

On Mon, Jul 22, 2019 at 05:03:02PM +0200, Bartosz Golaszewski wrote:

quoted

From: Bartosz Golaszewski <redacted>

Instead of dereferencing pdev each time, use a helper variable for
the associated device pointer.

quoted

 static int gpio_backlight_probe(struct platform_device *pdev)
 {
-     struct gpio_backlight_platform_data *pdata =
-             dev_get_platdata(&pdev->dev);
+     struct gpio_backlight_platform_data *pdata;
      struct backlight_properties props;
      struct backlight_device *bl;
      struct gpio_backlight *gbl;
      enum gpiod_flags flags;
+     struct device *dev;

Can't we do

        struct device dev = &pdev->dev;
        struct gpio_backlight_platform_data *pdata = dev_get_platdata(dev);

? It fits 80 nicely.

IMO it's more readable like that with the reverse christmas tree layout.

Bart