video: fbdev: nvidia: Remove dead code

Started by Souptick Joarder on Jul 10, 2019 · 3 messages from 2 authors · Last reply Jul 23, 2019

Subsystems (3)

Maintainers (3)

STALE2671d LANDED

Status: Landed in mainline as 9b9f35e7c659 on 2019-07-23.

open the first message on its own page

Souptick Joarder

Message details and related content
Open message details and related content
This is dead code since 3.15. If there is no plan to use it
further, this can be removed forever.

Signed-off-by: Souptick Joarder <redacted>
---
 drivers/video/fbdev/nvidia/nv_setup.c | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c
index b17acd2..2fa6866 100644
--- a/drivers/video/fbdev/nvidia/nv_setup.c
+++ b/drivers/video/fbdev/nvidia/nv_setup.c
@@ -119,34 +119,10 @@ u8 NVReadMiscOut(struct nvidia_par *par)
 {
 	return (VGA_RD08(par->PVIO, VGA_MIS_R));
 }
-#if 0
-void NVEnablePalette(struct nvidia_par *par)
-{
-	volatile u8 tmp;
-
-	tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
-	VGA_WR08(par->PCIO, VGA_ATT_IW, 0x00);
-	par->paletteEnabled = 1;
-}
-void NVDisablePalette(struct nvidia_par *par)
-{
-	volatile u8 tmp;
-
-	tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
-	VGA_WR08(par->PCIO, VGA_ATT_IW, 0x20);
-	par->paletteEnabled = 0;
-}
-#endif  /*  0  */
 void NVWriteDacMask(struct nvidia_par *par, u8 value)
 {
 	VGA_WR08(par->PDIO, VGA_PEL_MSK, value);
 }
-#if 0
-u8 NVReadDacMask(struct nvidia_par *par)
-{
-	return (VGA_RD08(par->PDIO, VGA_PEL_MSK));
-}
-#endif  /*  0  */
 void NVWriteDacReadAddr(struct nvidia_par *par, u8 value)
 {
 	VGA_WR08(par->PDIO, VGA_PEL_IR, value);
-- 
1.9.1

Souptick Joarder replied to Souptick Joarder

Message details and related content
Open message details and related content
On Wed, Jul 10, 2019 at 11:41 PM Souptick Joarder [off-list ref] wrote:
This is dead code since 3.15. If there is no plan to use it
further, this can be removed forever.
Any comment on this patch ?
quoted hunk
Signed-off-by: Souptick Joarder <redacted>
---
 drivers/video/fbdev/nvidia/nv_setup.c | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c
index b17acd2..2fa6866 100644
--- a/drivers/video/fbdev/nvidia/nv_setup.c
+++ b/drivers/video/fbdev/nvidia/nv_setup.c
@@ -119,34 +119,10 @@ u8 NVReadMiscOut(struct nvidia_par *par)
 {
        return (VGA_RD08(par->PVIO, VGA_MIS_R));
 }
-#if 0
-void NVEnablePalette(struct nvidia_par *par)
-{
-       volatile u8 tmp;
-
-       tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
-       VGA_WR08(par->PCIO, VGA_ATT_IW, 0x00);
-       par->paletteEnabled = 1;
-}
-void NVDisablePalette(struct nvidia_par *par)
-{
-       volatile u8 tmp;
-
-       tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
-       VGA_WR08(par->PCIO, VGA_ATT_IW, 0x20);
-       par->paletteEnabled = 0;
-}
-#endif  /*  0  */
 void NVWriteDacMask(struct nvidia_par *par, u8 value)
 {
        VGA_WR08(par->PDIO, VGA_PEL_MSK, value);
 }
-#if 0
-u8 NVReadDacMask(struct nvidia_par *par)
-{
-       return (VGA_RD08(par->PDIO, VGA_PEL_MSK));

8 more quoted lines

Bartlomiej Zolnierkiewicz replied to Souptick Joarder

Message details and related content
Open message details and related content
On 7/22/19 10:26 AM, Souptick Joarder wrote:
On Wed, Jul 10, 2019 at 11:41 PM Souptick Joarder [off-list ref] wrote:
quoted
This is dead code since 3.15. If there is no plan to use it
further, this can be removed forever.
Any comment on this patch ?
quoted
Signed-off-by: Souptick Joarder <redacted>
Patch queued for v5.4, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help