[PATCH] video: fbdev: nvidia: Remove dead code

Subsystems: framebuffer layer, nvidia (rivafb and nvidiafb) framebuffer driver, the rest

STALE2579d

3 messages, 2 authors, 2019-07-23 · open the first message on its own page

[PATCH] video: fbdev: nvidia: Remove dead code

From: Souptick Joarder <hidden>
Date: 2019-07-10 18:11:04 

This is dead code since 3.15. If there is no plan to use it
further, this can be removed forever.

Signed-off-by: Souptick Joarder <redacted>
---
 drivers/video/fbdev/nvidia/nv_setup.c | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c
index b17acd2..2fa6866 100644
--- a/drivers/video/fbdev/nvidia/nv_setup.c
+++ b/drivers/video/fbdev/nvidia/nv_setup.c
@@ -119,34 +119,10 @@ u8 NVReadMiscOut(struct nvidia_par *par)
 {
 	return (VGA_RD08(par->PVIO, VGA_MIS_R));
 }
-#if 0
-void NVEnablePalette(struct nvidia_par *par)
-{
-	volatile u8 tmp;
-
-	tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
-	VGA_WR08(par->PCIO, VGA_ATT_IW, 0x00);
-	par->paletteEnabled = 1;
-}
-void NVDisablePalette(struct nvidia_par *par)
-{
-	volatile u8 tmp;
-
-	tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
-	VGA_WR08(par->PCIO, VGA_ATT_IW, 0x20);
-	par->paletteEnabled = 0;
-}
-#endif  /*  0  */
 void NVWriteDacMask(struct nvidia_par *par, u8 value)
 {
 	VGA_WR08(par->PDIO, VGA_PEL_MSK, value);
 }
-#if 0
-u8 NVReadDacMask(struct nvidia_par *par)
-{
-	return (VGA_RD08(par->PDIO, VGA_PEL_MSK));
-}
-#endif  /*  0  */
 void NVWriteDacReadAddr(struct nvidia_par *par, u8 value)
 {
 	VGA_WR08(par->PDIO, VGA_PEL_IR, value);
-- 
1.9.1

Re: [PATCH] video: fbdev: nvidia: Remove dead code

From: Souptick Joarder <hidden>
Date: 2019-07-22 08:27:07 

On Wed, Jul 10, 2019 at 11:41 PM Souptick Joarder [off-list ref] wrote:
This is dead code since 3.15. If there is no plan to use it
further, this can be removed forever.
Any comment on this patch ?
quoted hunk
Signed-off-by: Souptick Joarder <redacted>
---
 drivers/video/fbdev/nvidia/nv_setup.c | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c
index b17acd2..2fa6866 100644
--- a/drivers/video/fbdev/nvidia/nv_setup.c
+++ b/drivers/video/fbdev/nvidia/nv_setup.c
@@ -119,34 +119,10 @@ u8 NVReadMiscOut(struct nvidia_par *par)
 {
        return (VGA_RD08(par->PVIO, VGA_MIS_R));
 }
-#if 0
-void NVEnablePalette(struct nvidia_par *par)
-{
-       volatile u8 tmp;
-
-       tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
-       VGA_WR08(par->PCIO, VGA_ATT_IW, 0x00);
-       par->paletteEnabled = 1;
-}
-void NVDisablePalette(struct nvidia_par *par)
-{
-       volatile u8 tmp;
-
-       tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
-       VGA_WR08(par->PCIO, VGA_ATT_IW, 0x20);
-       par->paletteEnabled = 0;
-}
-#endif  /*  0  */
 void NVWriteDacMask(struct nvidia_par *par, u8 value)
 {
        VGA_WR08(par->PDIO, VGA_PEL_MSK, value);
 }
-#if 0
-u8 NVReadDacMask(struct nvidia_par *par)
-{
-       return (VGA_RD08(par->PDIO, VGA_PEL_MSK));
-}
-#endif  /*  0  */
 void NVWriteDacReadAddr(struct nvidia_par *par, u8 value)
 {
        VGA_WR08(par->PDIO, VGA_PEL_IR, value);
--
1.9.1

Re: [PATCH] video: fbdev: nvidia: Remove dead code

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2019-07-23 15:36:53 

On 7/22/19 10:26 AM, Souptick Joarder wrote:
On Wed, Jul 10, 2019 at 11:41 PM Souptick Joarder [off-list ref] wrote:
quoted
This is dead code since 3.15. If there is no plan to use it
further, this can be removed forever.
Any comment on this patch ?
quoted
Signed-off-by: Souptick Joarder <redacted>
Patch queued for v5.4, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help