[PATCH] video: fbdev: nvidia: Remove extra return

Subsystems: framebuffer layer, nvidia (rivafb and nvidiafb) framebuffer driver, the rest

STALE2570d

3 messages, 2 authors, 2019-07-23 · open the first message on its own page

[PATCH] video: fbdev: nvidia: Remove extra return

From: Souptick Joarder <hidden>
Date: 2019-07-10 17:58:38

Minor cleanup to remove extra return statement.

Signed-off-by: Souptick Joarder <redacted>
---
 drivers/video/fbdev/nvidia/nv_backlight.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/nvidia/nv_backlight.c b/drivers/video/fbdev/nvidia/nv_backlight.c
index e705a78..2ce5352 100644
--- a/drivers/video/fbdev/nvidia/nv_backlight.c
+++ b/drivers/video/fbdev/nvidia/nv_backlight.c
@@ -123,8 +123,6 @@ void nvidia_bl_init(struct nvidia_par *par)
 
 	printk("nvidia: Backlight initialized (%s)\n", name);
 
-	return;
-
 error:
 	return;
 }
-- 
1.9.1

Re: [PATCH] video: fbdev: nvidia: Remove extra return

From: Souptick Joarder <hidden>
Date: 2019-07-22 08:26:42

On Wed, Jul 10, 2019 at 11:28 PM Souptick Joarder [off-list ref] wrote:
Minor cleanup to remove extra return statement.
Any comment on this patch ?
quoted hunk
Signed-off-by: Souptick Joarder <redacted>
---
 drivers/video/fbdev/nvidia/nv_backlight.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/nvidia/nv_backlight.c b/drivers/video/fbdev/nvidia/nv_backlight.c
index e705a78..2ce5352 100644
--- a/drivers/video/fbdev/nvidia/nv_backlight.c
+++ b/drivers/video/fbdev/nvidia/nv_backlight.c
@@ -123,8 +123,6 @@ void nvidia_bl_init(struct nvidia_par *par)

        printk("nvidia: Backlight initialized (%s)\n", name);

-       return;
-
 error:
        return;
 }
--
1.9.1

Re: [PATCH] video: fbdev: nvidia: Remove extra return

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2019-07-23 15:36:32

On 7/22/19 10:26 AM, Souptick Joarder wrote:
On Wed, Jul 10, 2019 at 11:28 PM Souptick Joarder [off-list ref] wrote:
quoted
Minor cleanup to remove extra return statement.
Any comment on this patch ?
quoted
Signed-off-by: Souptick Joarder <redacted>
Patch queued for v5.4, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help