Re: [PATCH] staging: fbtft: Fix checkpatch ERROR: space prohibited before that close parenthesis ')'
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2019-06-17 08:06:54
Also in:
dri-devel
Hi Shobhit, Thanks for your patch! On Fri, Jun 14, 2019 at 4:34 AM Shobhit Kukreti [off-list ref] wrote:
Cleaned up code to resolve the checkpatch error ERROR: space prohibited before that close parenthesis ')' from the file: fbtft/fbtft-bus.c
IMHO that is a bogus checkpatch error...
quoted hunk ↗ jump to hunk
Signed-off-by: Shobhit Kukreti <redacted> --- drivers/staging/fbtft/fbtft-bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c index 2ea814d..2b43bc2 100644 --- a/drivers/staging/fbtft/fbtft-bus.c +++ b/drivers/staging/fbtft/fbtft-bus.c@@ -62,9 +62,9 @@ out: \ } \ EXPORT_SYMBOL(func); -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,) define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16) -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, ) +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)
... as the space is the (mandatory) separator between the comma and the
(empty) last parameter value.
Checkpatch has some limitations when parsing the C preprocessor macro
languagage.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds