Re: [PATCH] efifb: BGRT: Add check for new BGRT status field rotation bits

On Mon, 10 Jun 2019 at 17:12, Ard Biesheuvel [off-list ref] wrote:

On Wed, 29 May 2019 at 17:46, Hans de Goede [off-list ref] wrote:

quoted

Starting with ACPI 6.2 bits 1 and 2 of the BGRT status field are no longer
reserved. These bits are now used to indicate if the image needs to be
rotated before being displayed.

The efifb code does not support rotating the image before copying it to
the screen.

This commit adds a check for these new bits and if they are set leaves the
fb contents as is instead of trying to use the un-rotated BGRT image.

Signed-off-by: Hans de Goede <redacted>

Acked-by: Ard Biesheuvel <redacted>

BTW should we make sure that this patch and the efi-bgrt patch get
merged at the same time? I guess the net result is just that we get
rid of some error in the log, but a rotated BMP will be ignored
otherwise. Or is it relevant for userland in some other way?