Re: [PATCH v2 4/4] backlight: pwm_bl: Set scale type for brightness curves specified in the DT

From
Daniel Thompson <hidden>
Date
2019-06-28 07:55:24
Also in
dri-devel, linux-pwm, lkml
Reply to
Pavel Machek, 2019-06-26
On Wed, Jun 26, 2019 at 04:56:18PM +0200, Pavel Machek wrote:
On Mon 2019-06-24 13:31:13, Matthias Kaehlcke wrote:
quoted
Check if a brightness curve specified in the device tree is linear or
not and set the corresponding property accordingly. This makes the
scale type available to userspace via the 'scale' sysfs attribute.

To determine if a curve is linear it is compared to a interpolated linear
curve between min and max brightness. The curve is considered linear if
no value deviates more than +/-5% of ${brightness_range} from their
interpolated value.
I don't think this works. Some hardware does takes brightness in perceptual units,
converting it in the LED controller.
This check is exclusive to PWM backlights so I'd like to double check
that you are thinking specifically of hardware that takes it's signal
from the PWM and works in perceptual units?

I don't recall any examples being offered when we reviewed the
auto-generated CIE tables (although since that can be overriden by DT it
was not of the same gravity and this example).


Daniel.
Thread (11 messages) 11 messages, 3 authors, last reply 2019-07-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help