Thread (8 messages) 8 messages, 4 authors, 2019-07-05

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

From: Gustavo A. R. Silva <hidden>
Date: 2019-06-25 17:06:22
Also in: dri-devel, linux-kbuild, lkml


On 6/25/19 11:52 AM, Joe Perches wrote:
On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote:
quoted
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
[]
quoted
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Just enable the thing already.

If you stopped trying to do it all yourself, others
What are you talking about?

Anyone can enable it, I'm adding this to every commit:

Warning level 3 was used: -Wimplicit-fallthrough=3

And I'll send a PR with a proper patch for the Makefile
during the next merge window.

If had the power I would have enabled this option since day 1,
so every developer can take care of their own code.

Lately, you are not being of much help, Joe.

--
Gustavo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help