Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

On Tue, 2019-06-25 at 15:06 +1000, Alastair D'Silva wrote:

On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote:

quoted

On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote:

quoted

From: Alastair D'Silva <redacted>

In order to support additional features, rename hex_dump_to_buffer
to
hex_dump_to_buffer_ext, and replace the ascii bool parameter with
flags.

[]

quoted

diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c

b/drivers/gpu/drm/i915/intel_engine_cs.c

[]

quoted

@@ -1338,9 +1338,8 @@ static void hexdump(struct drm_printer *m,

const void *buf, size_t len)
 		}
 
 		WARN_ON_ONCE(hex_dump_to_buffer(buf + pos, len - pos,
-						rowsize, sizeof(u32),
-						line, sizeof(line),
-						false) >> > > sizeof(line));
+						rowsize, sizeof(u32),
line,
+						sizeof(line)) >> > > sizeof(line));

Huh?  Why do this?

[]

The change actions Jani's suggestion:
https://lkml.org/lkml/2019/6/20/343

I think you need to read this change again.