Thread (18 messages) 18 messages, 5 authors, 2019-06-20

Re: [PATCH v3 3/7] lib/hexdump.c: Optionally suppress lines of repeated bytes

From: Alastair D'Silva <hidden>
Date: 2019-06-17 04:07:51
Also in: dri-devel, intel-gfx, linux-fsdevel, linux-scsi, linux-wireless, lkml, netdev

On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote:
quoted hunk ↗ jump to hunk
From: Alastair D'Silva <redacted>

Some buffers may only be partially filled with useful data, while the
rest
is padded (typically with 0x00 or 0xff).

This patch introduces a flag to allow the supression of lines of
repeated
bytes, which are replaced with '** Skipped %u bytes of value 0x%x **'

An inline wrapper function is provided for backwards compatibility
with
existing code, which maintains the original behaviour.

Signed-off-by: Alastair D'Silva <redacted>
---
 include/linux/printk.h | 25 +++++++++---
 lib/hexdump.c          | 91 ++++++++++++++++++++++++++++++++++++--
----
 2 files changed, 99 insertions(+), 17 deletions(-)
diff --git a/include/linux/printk.h b/include/linux/printk.h
index cefd374c47b1..d7754799cfe0 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -481,13 +481,18 @@ enum {
 	DUMP_PREFIX_ADDRESS,
 	DUMP_PREFIX_OFFSET
 };
+
 extern int hex_dump_to_buffer(const void *buf, size_t len, int
rowsize,
 			      int groupsize, char *linebuf, size_t
linebuflen,
 			      bool ascii);
+
+#define HEXDUMP_ASCII			BIT(0)
+#define HEXDUMP_SUPPRESS_REPEATED	BIT(1)
+
This is missing the include of linux/bits.h, I'll fix this in the next
version.

-- 
Alastair D'Silva           mob: 0423 762 819
skype: alastair_dsilva    
Twitter: @EvilDeece
blog: http://alastair.d-silva.org
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help