Re: [PATCH] vt/fbcon: deinitialize resources in visual_init() after failed memory allocation

From
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date
2019-05-24 08:06:06
Also in
lkml
Reply to
Grzegorz Halat, 2019-05-16
On Thu, May 16, 2019 at 04:33:40PM +0200, Grzegorz Halat wrote:
On Fri, 26 Apr 2019 at 16:59, Grzegorz Halat [off-list ref] wrote:
quoted
After memory allocation failure vc_allocate() doesn't clean up data
which has been initialized in visual_init(). In case of fbcon this
leads to divide-by-0 in fbcon_init() on next open of the same tty.
Hi,
A gentle reminder. Could you please review my patch? I've seen two
crashes caused by this bug.
How?  How are you triggering a memory allocation failure in a "normal"
system?

Anyway, I'll queue this up, but it really does not seem like anything
anyone would see "in the wild".

thanks,

greg k-h
Thread (6 messages) 6 messages, 3 authors, last reply 2019-05-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help