On Wed, 2019-05-08 at 17:58 -0700, Randy Dunlap wrote:

On 5/8/19 12:01 AM, Alastair D'Silva wrote:

quoted

From: Alastair D'Silva <redacted>

Some buffers may only be partially filled with useful data, while
the rest
is padded (typically with 0x00 or 0xff).

This patch introduces a flag to allow the supression of lines of
repeated
bytes, which are replaced with '** Skipped %u bytes of value 0x%x
**'

An inline wrapper function is provided for backwards compatibility
with
existing code, which maintains the original behaviour.

Signed-off-by: Alastair D'Silva <redacted>
---
 include/linux/printk.h | 25 +++++++++---
 lib/hexdump.c          | 91 ++++++++++++++++++++++++++++++++++++
------
 2 files changed, 99 insertions(+), 17 deletions(-)

Hi,
Did you do "make htmldocs" or something similar on this?

quoted

diff --git a/lib/hexdump.c b/lib/hexdump.c
index 3943507bc0e9..d61a1e4f19fa 100644
--- a/lib/hexdump.c
+++ b/lib/hexdump.c

@@ -212,8 +212,44 @@ int hex_dump_to_buffer(const void *buf, size_t

len, int rowsize, int groupsize,
 EXPORT_SYMBOL(hex_dump_to_buffer);
 
 #ifdef CONFIG_PRINTK
+
+/**
+ * Check if a buffer contains only a single byte value
+ * @buf: pointer to the buffer
+ * @len: the size of the buffer in bytes
+ * @val: outputs the value if if the bytes are identical

Does this work without a function name?
Documentation/doc-guide/kernel-doc.rst says the general format is:

  /**
   * function_name() - Brief description of function.
   * @arg1: Describe the first argument.
   * @arg2: Describe the second argument.
   *        One can provide multiple line descriptions
   *        for arguments.
   *

quoted

+ */
 /**
- * print_hex_dump - print a text hex dump to syslog for a binary
blob of data
+ * print_hex_dump_ext: dump a binary blob of data to syslog in
hexadecimal

Also not in the general documented format.

Thanks Randy, I'll address these.

-- 
Alastair D'Silva           mob: 0423 762 819
skype: alastair_dsilva    
Twitter: @EvilDeece
blog: http://alastair.d-silva.org