Thread (8 messages) 8 messages, 3 authors, 2019-05-06

Re: [PATCH v5 2/2] fbcon: Silence fbcon logo on 'quiet' boots

From: Prarit Bhargava <hidden>
Date: 2019-04-02 11:31:55
Also in: dri-devel


On 4/1/19 3:31 PM, Andreas Schwab wrote:
On Jan 29 2019, Prarit Bhargava [off-list ref] wrote:
quoted
@@ -1066,6 +1069,9 @@ static void fbcon_init(struct vc_data *vc, int init)
 
 	cap = info->flags;
 
+	if (console_loglevel <= CONSOLE_LOGLEVEL_QUIET)
+		logo_shown = FBCON_LOGO_DONTSHOW;
+
 	if (vc != svc || logo_shown = FBCON_LOGO_DONTSHOW ||
 	    (info->fix.type = FB_TYPE_TEXT))
 		logo = 0;
This causes the scroll region to no longer be reset when the logo is
removed.
Andreas, my apologies but I'm not sure what you mean.  Could you elaborate on
the broken and expected behaviour?

I'm absolutely not disputing that there's a bug.

Thanks,

P.
Andreas.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help