Thread (3 messages) 3 messages, 2 authors, 2019-03-14

Re: [RfC PATCH] fbdev: list all memory bars as conflicting apertures

From: Gerd Hoffmann <kraxel@redhat.com>
Date: 2019-03-14 11:31:04
Also in: dri-devel, lkml

On Thu, Mar 14, 2019 at 11:37:13AM +0100, Daniel Vetter wrote:
On Wed, Mar 13, 2019 at 12:07:41PM +0100, Gerd Hoffmann wrote:
quoted
Simply add all pci memory bars to struct apertures_struct in
remove_conflicting_pci_framebuffers().  That allows to drop
the res_id parameter.

TODO: actually remove the res_id parameter.
I think best to do that in a cleanup patch afterwards.
I was just lazy and didn't want update all callers for the first patch
draft.  But doing a test run ...
Maybe if you want to be paranoid in the conversion add a check that we're
not skipping the pci bar requested in res_id. Then we could test this for
a kernel and remove the parameter later on.
... that way before actually dropping the parameter surely makes sense.

New version on the way,
  Gerd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help