[PATCH] xen, fbfront: mark expected switch fall-through

Subsystems: framebuffer layer, the rest, xen hypervisor interface

STALE2697d

5 messages, 3 authors, 2019-04-01 · open the first message on its own page

[PATCH] xen, fbfront: mark expected switch fall-through

From: Gustavo A. R. Silva <hidden>
Date: 2019-02-27 20:53:09 

In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (dev->state = XenbusStateClosed)
      ^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
  case XenbusStateClosing:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
 drivers/video/fbdev/xen-fbfront.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 6a4bbc9e1fb0..a3d6b6db221b 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
 	case XenbusStateClosed:
 		if (dev->state = XenbusStateClosed)
 			break;
-		/* Missed the backend's CLOSING state -- fallthrough */
+		/* fall through - Missed the backend's CLOSING state. */
 	case XenbusStateClosing:
 		xenbus_frontend_closed(dev);
 		break;
-- 
2.21.0

Re: [PATCH] xen, fbfront: mark expected switch fall-through

From: Oleksandr Andrushchenko <hidden>
Date: 2019-02-28 11:51:59 

+Xen-devel list

On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
quoted hunk
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (dev->state = XenbusStateClosed)
       ^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
   case XenbusStateClosing:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
  drivers/video/fbdev/xen-fbfront.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 6a4bbc9e1fb0..a3d6b6db221b 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
  	case XenbusStateClosed:
  		if (dev->state = XenbusStateClosed)
  			break;
-		/* Missed the backend's CLOSING state -- fallthrough */
+		/* fall through - Missed the backend's CLOSING state. */
  	case XenbusStateClosing:
  		xenbus_frontend_closed(dev);
  		break;

Re: [PATCH] xen, fbfront: mark expected switch fall-through

From: Gustavo A. R. Silva <hidden>
Date: 2019-03-20 20:09:46 

Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

On 2/28/19 5:51 AM, Oleksandr Andrushchenko wrote:
+Xen-devel list

On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
quoted
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (dev->state = XenbusStateClosed)
       ^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
   case XenbusStateClosing:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
  drivers/video/fbdev/xen-fbfront.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 6a4bbc9e1fb0..a3d6b6db221b 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
      case XenbusStateClosed:
          if (dev->state = XenbusStateClosed)
              break;
-        /* Missed the backend's CLOSING state -- fallthrough */
+        /* fall through - Missed the backend's CLOSING state. */
      case XenbusStateClosing:
          xenbus_frontend_closed(dev);
          break;

Re: [PATCH] xen, fbfront: mark expected switch fall-through

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2019-03-21 11:03:18 

Hi,

On 03/20/2019 09:08 PM, Gustavo A. R. Silva wrote:
Hi all,

Friendly ping:

Who can take this?
I'll take this for v5.2.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Thanks
--
Gustavo

On 2/28/19 5:51 AM, Oleksandr Andrushchenko wrote:
quoted
+Xen-devel list

On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
quoted
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (dev->state = XenbusStateClosed)
       ^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
   case XenbusStateClosing:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
  drivers/video/fbdev/xen-fbfront.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 6a4bbc9e1fb0..a3d6b6db221b 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
      case XenbusStateClosed:
          if (dev->state = XenbusStateClosed)
              break;
-        /* Missed the backend's CLOSING state -- fallthrough */
+        /* fall through - Missed the backend's CLOSING state. */
      case XenbusStateClosing:
          xenbus_frontend_closed(dev);
          break;

Re: [PATCH] xen, fbfront: mark expected switch fall-through

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2019-04-01 12:54:58 

On 03/21/2019 12:03 PM, Bartlomiej Zolnierkiewicz wrote:
Hi,

On 03/20/2019 09:08 PM, Gustavo A. R. Silva wrote:
quoted
Hi all,

Friendly ping:

Who can take this?
I'll take this for v5.2.
Patch queued for v5.2, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help