Re: [PATCH] video/macfb: Remove redundant code

From
Geert Uytterhoeven <geert@linux-m68k.org>
Date
2019-02-15 08:25:47
Also in
dri-devel, lkml
Reply to
Finn Thain, 2019-02-14
On Fri, Feb 15, 2019 at 3:19 AM Finn Thain [off-list ref] wrote:
The value of info->var.bits_per_pixel get checked in macfb_setcolreg().
Remove additional checks as they are redundant.

macfb_defined.activate gets initialized to FB_ACTIVATE_NOW by the struct
initializer. Remove redundant assignments.

macfb_defined.bits_per_pixel, .width and .height all get assigned
unconditionally. Remove redundant initializers.

Cc: <redacted>
Tested-by: Stan Johnson <redacted>
Signed-off-by: Finn Thain <redacted>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Thread (3 messages) 3 messages, 3 authors, last reply 2019-04-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help