Re: [PATCH v3] fbcon: Silence fbcon logo on 'quiet' boots

From
Geert Uytterhoeven <geert@linux-m68k.org>
Date
2019-01-03 10:39:07
Also in
dri-devel
Reply to
Petr Mladek, 2019-01-02
Hi Petr,

On Wed, Jan 2, 2019 at 6:43 PM Petr Mladek [off-list ref] wrote:
On Thu 2018-12-20 17:31:57, Bartlomiej Zolnierkiewicz wrote:
quoted
[ added Petr & Sergey to Cc: ]

Hi,

On 10/30/2018 04:44 PM, Prarit Bhargava wrote:
quoted
On text-based systems the 'quiet' boot option will show printk levels
higher than CONSOLE_LOGLEVEL_QUIET.  The displaying of the Tux logo
during boot can cause some consoles to lose display data and as a result
confuse the end user.

Do not display the Tux logo on systems that are in 'quiet' boot.

v2: It helps to commit all my changes before sending them.  Remove extra
bracket.
v3: buildbot error fix: fbcon can be built as part of a module so export console_printk

Signed-off-by: Prarit Bhargava <redacted>
Cc: Hans de Goede <redacted>
Cc: Marko Myllynen <redacted>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Kees Cook <redacted>
Cc: Daniel Vetter <redacted>
Cc: Thierry Reding <redacted>
Cc: Yisheng Xie <redacted>
Cc: <redacted>
quoted
quoted
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -66,6 +66,7 @@ int console_printk[4] = {
    CONSOLE_LOGLEVEL_MIN,           /* minimum_console_loglevel */
    CONSOLE_LOGLEVEL_DEFAULT,       /* default_console_loglevel */
 };
+EXPORT_SYMBOL(console_printk);
You need printk Maintainers Ack on it.
I am fine with the added export (as a printk maintainer).
EXPORT_SYMBOL_GPL()?

The file seems to use a strange mix of both...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Thread (15 messages) 15 messages, 6 authors, last reply 2019-01-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help