Hi Peter,

On Mon, Jan 7, 2019 at 9:26 AM Peter Rosin [off-list ref] wrote:

On 2019-01-06 10:33, Geert Uytterhoeven wrote:

quoted

On Mon, Nov 26, 2018 at 10:59 PM Peter Rosin [off-list ref] wrote:

quoted

If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these
extra logos are not considered when centering the first logo vertically.

Signed-off-by: Peter Rosin <redacted>

quoted

--- a/drivers/video/logo/Kconfig
+++ b/drivers/video/logo/Kconfig

@@ -10,6 +10,15 @@ menuconfig LOGO

 if LOGO

+config FB_LOGO_CENTER
+       bool "Center the logo"
+       depends on FB=y
+       help
+         When this option is selected, the bootup logo is centered both
+         horizontally and vertically. If more than one logo is displayed
+         due to multiple CPUs, the collected line of logos is centered
+         as a whole.
+

Isn't a kernel command line option more suitable to configure the position
of the logo?

That didn't occur to me previously, but it does make sense now that you
mention it. This is on top of v5.0-rc1, and if applied before v5.0 we
can avoid possible regressions for folks who might start to rely on
CONFIG_FB_LOGO_CENTER if v5.0 is released w/o this.

Cheers,
Peter

From de7353ab519ba9b5c9ea3f62d607bb8e94b687cc Mon Sep 17 00:00:00 2001
From: Peter Rosin <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Peter Rosin <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Cc: linux-doc@vger.kernel.org
To: linux-kernel@vger.kernel.org
Date: Mon, 7 Jan 2019 08:35:26 +0100
Subject: [PATCH] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd line
 option

A command line option is much more flexible than a config option and
the supporting code is small. Gets rid of #ifdefs in the code too...

Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Peter Rosin <redacted>

Thanks for your patch!

What about making this more generic, than an option specific for centering?
Else people want fbcon=left-logo or fbcon=right-logo soon?

    fbcon=logo-pos:<pos>

With <pos> being "center", "left", "top", "right", "bottom", and combinations
like "top,center"? Or is that complicating stuff too much?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds