Re: [PATCH 2/2] backlight: lm3630a: add backlight driver match_table
flat view
From: Daniel Thompson <hidden>
Date: 2018-11-27 10:57:40
Also in:
dri-devel, linux-devicetree, lkml
On Sat, Nov 24, 2018 at 09:17:03AM -0500, Brian Masney wrote:
quoted hunk ↗ jump to hunk
From: Jonathan Marek <redacted> Add device tree support to the lm3630a driver. Signed-off-by: Jonathan Marek <redacted> [masneyb@onstation.org: checkpatch fixes; add 'a' to compatible string] Signed-off-by: Brian Masney <redacted> --- This is part of upstreaming various components of the LG Nexus 5 (hammerhead) phone. drivers/video/backlight/lm3630a_bl.c | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index 2030a6b77a09..159d4013d9c2 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c@@ -470,11 +470,18 @@ static const struct i2c_device_id lm3630a_id[] = { {} };
Similar to my reply to the DT bindings: I would have expected there to be code to handle DT properties here. Daniel.
+static const struct of_device_id lm3630a_match_table[] = {
+ { .compatible = "ti,lm3630a", },
+ { },
+};
+
+
MODULE_DEVICE_TABLE(i2c, lm3630a_id);
static struct i2c_driver lm3630a_i2c_driver = {
.driver = {
.name = LM3630A_NAME,
+ .of_match_table = lm3630a_match_table,
},
.probe = lm3630a_probe,
.remove = lm3630a_remove,
--
2.17.2