On Mon, Nov 26, 2018 at 6:25 AM Vokáč Michal [off-list ref] wrote:
On 19.11.2018 23:32, Rob Herring wrote:
quoted
On Mon, Nov 19, 2018 at 9:12 AM Vokáč Michal [off-list ref] wrote:
quoted
On 12.11.2018 17:55, Rob Herring wrote:
quoted
On Fri, Nov 02, 2018 at 02:56:35PM +0000, Vokáč Michal wrote:
quoted
The SSD130x OLED display reset signal is active low. Now the reset
sequence is implemented in such a way that DTS authors are forced to
define the reset-gpios property with GPIO_ACTIVE_HIGH to make the reset
work.
Add the reset-active-low property so the signal is inverted once again
and the GPIO_ACTIVE_LOW work as expected.
Signed-off-by: Michal Vokáč <redacted>
---
drivers/video/fbdev/ssd1307fb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index e7ae135..790f1c4 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -608,6 +608,7 @@ static int ssd1307fb_probe(struct i2c_client *client,
struct fb_deferred_io *ssd1307fb_defio;
u32 vmem_size;
struct ssd1307fb_par *par;
+ bool reset_active_low;
u8 *vmem;
int ret;
@@ -671,6 +672,7 @@ static int ssd1307fb_probe(struct i2c_client *client,
par->com_seq = of_property_read_bool(node, "solomon,com-seq");
par->com_lrremap = of_property_read_bool(node, "solomon,com-lrremap");
par->com_invdir = of_property_read_bool(node, "solomon,com-invdir");
+ reset_active_low = of_property_read_bool(node, "reset-active-low");
par->contrast = 127;
par->vcomh = par->device_info->default_vcomh;@@ -728,9 +730,9 @@ static int ssd1307fb_probe(struct i2c_client *client,
60 more quoted lines
Yes, that one.
I am also not sure where to look for the example. When you say
Versatile platform code I tend to look into plat-versatile or
mach-versatile. I could not find anything I could use as an example
in there. I think that is not what you meant.
See versatile_dt_pci_init(). Or look for other callers of of_update_property().
Regarding the 2nd option, you suggest to use of_machine_is_compatible
to decide what reset sequence to use? In case of imx28-cfa10036 use
the old 0 -> 1, in all other cases use a new correct sequence 1 -> 0?
That also does not seem right.
Correct. Though if you fix imx28-cfa10036 dts, then you have to handle
that case too.
Why is it not right? Ugly yes, but it's not wrong.
Rob