Re: [PATCH v2 1/1] atmel_lcdfb: support native-mode display-timings

From
Bartlomiej Zolnierkiewicz <hidden>
Date
2018-10-08 10:41:18
Also in
dri-devel, lkml
Reply to
Sam Ravnborg, 2018-08-25
On 08/25/2018 08:23 PM, Sam Ravnborg wrote:
When a device tree set a display-timing using native-mode
then according to the bindings doc this should:

    native-mode:
    The native mode for the display, in case multiple
    modes are provided.
    When omitted, assume the first node is the native.

The atmel_lcdfb used the last timing subnode and did not
respect the timing mode specified with native-mode.

Introduce use of of_get_videomode() which allowed
a nice simplification of the code while also
added support for native-mode.

As a nice side-effect this fixes a memory leak where the
data used for timings and the display_np was not freed.

Signed-off-by: Sam Ravnborg <redacted>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Patch queued for 4.20, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Thread (2 messages) 2 messages, 2 authors, last reply 2018-10-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help