Thread (3 messages) 3 messages, 3 authors, 2018-09-26

Re: [PATCH] efifb: BGRT: Add nobgrt option

From: David Herrmann <hidden>
Date: 2018-09-13 06:51:58
Also in: dri-devel

Hi

On Wed, Sep 12, 2018 at 11:12 AM Hans de Goede [off-list ref] wrote:
In some setups restoring the BGRT logo is undesirable, allow passing
videoïifb:nobgrt on the kernel commandline to disable it.

Cc: David Herrmann <redacted>
Reported-by: David Herrmann <redacted>
Signed-off-by: Hans de Goede <redacted>
---
 drivers/video/fbdev/efifb.c | 6 ++++++
 1 file changed, 6 insertions(+)
Reviewed-by: David Herrmann <redacted>

Thanks a lot!
David
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index 3946649b85c8..ba906876cc45 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -42,6 +42,7 @@ struct bmp_dib_header {
        u32 colors_important;
 } __packed;

+static bool use_bgrt = true;
 static bool request_mem_succeeded = false;
 static u64 mem_flags = EFI_MEMORY_WC | EFI_MEMORY_UC;
@@ -160,6 +161,9 @@ static void efifb_show_boot_graphics(struct fb_info *info)
        void *bgrt_image = NULL;
        u8 *dst = info->screen_base;

+       if (!use_bgrt)
+               return;
+
        if (!bgrt_tab.image_address) {
                pr_info("efifb: No BGRT, not showing boot graphics\n");
                return;
@@ -290,6 +294,8 @@ static int efifb_setup(char *options)
                                screen_info.lfb_width = simple_strtoul(this_opt+6, NULL, 0);
                        else if (!strcmp(this_opt, "nowc"))
                                mem_flags &= ~EFI_MEMORY_WC;
+                       else if (!strcmp(this_opt, "nobgrt"))
+                               use_bgrt = false;
                }
        }

--
2.19.0.rc0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help