Re: [PATCH 2/2] video: ssd1307fb: Do not hard code active-low reset sequence

From
Fabio Estevam <festevam@gmail.com>
Date
2018-09-19 12:12:43
Also in
linux-devicetree, lkml
Reply to
Michal Vokáč, 2018-09-19
Hi Michal,

On Wed, Sep 19, 2018 at 6:18 AM, Michal Vokáč [off-list ref] wrote:
The SSD130x OLED display reset signal is active low. Now the reset
sequence is implemented in such a way that users are forced to
define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work.

Do not hard code the active-low sequence into the driver but instead
allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect
the real world.

The only single in-tree user of the display is converted and builds
fine.

Signed-off-by: Michal Vokáč <redacted>
---
I am not really sure wheater this should be in one commit or the DT
changes should be done in separate commit. Just tell me and I will
split/merge the changes as you want. Thanks.
Please separate in two patches: one for the dts and another for the driver.

Thanks
Thread (5 messages) 5 messages, 2 authors, last reply 2018-09-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help