Thread (4 messages) 4 messages, 2 authors, 2018-08-27

Re: [PATCH v2 3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2018-08-27 16:42:32
Also in: dri-devel, linux-block, linuxppc-dev, lkml

On Mon, Aug 27, 2018 at 6:10 PM Christophe Leroy
[off-list ref] wrote:
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions.

Signed-off-by: Christophe Leroy <redacted>
From a Zorro bus point of view:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
quoted hunk ↗ jump to hunk
--- a/drivers/block/z2ram.c
+++ b/drivers/block/z2ram.c
@@ -190,8 +190,7 @@ static int z2_open(struct block_device *bdev, fmode_t mode)
                        vfree(vmalloc (size));
                }

-               vaddr = (unsigned long) __ioremap (paddr, size,
-                                                  _PAGE_WRITETHRU);
+               vaddr = (unsigned long)ioremap_wt(paddr, size);

 #else
                vaddr = (unsigned long)z_remap_nocache_nonser(paddr, size);
However, since the removal of APUS support, this file can no longer be
compiled on powerpc.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help