[PATCH] ddk750_mode.c: Wraps line to 80 charecters

Subsystems: staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest

STALE2929d

3 messages, 2 authors, 2018-08-27 · open the first message on its own page

[PATCH] ddk750_mode.c: Wraps line to 80 charecters

From: Abishek V Ashok <hidden>
Date: 2018-08-08 09:36:17

Splits definition of function programModeRegisters into two lines such
that each line is less than 80 characters.

Signed-off-by: Abishek V Ashok <redacted>
---
 drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 7e22d093b..57cf9e6a5 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -13,8 +13,8 @@
  * HW only supports 7 predefined pixel clocks, and clock select is
  * in bit 29:27 of Display Control register.
  */
-static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
-						  unsigned long dispControl)
+static unsigned long displayControlAdjust_SM750LE(
+		struct mode_parameter *pModeParam, unsigned long dispControl)
 {
 	unsigned long x, y;
 
-- 
2.18.0

Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2018-08-27 18:08:47

On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote:
Splits definition of function programModeRegisters into two lines such
that each line is less than 80 characters.

Signed-off-by: Abishek V Ashok <redacted>
---
 drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Please put the subsystem in the subject line to make it harder to miss
your patch, you need a "staging:" in there, like all other patches for
drivers/staging/

Please fix up and resend.


thanks,

greg k-h

Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2018-08-27 18:08:52

On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote:
quoted hunk
Splits definition of function programModeRegisters into two lines such
that each line is less than 80 characters.

Signed-off-by: Abishek V Ashok <redacted>
---
 drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 7e22d093b..57cf9e6a5 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -13,8 +13,8 @@
  * HW only supports 7 predefined pixel clocks, and clock select is
  * in bit 29:27 of Display Control register.
  */
-static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
-						  unsigned long dispControl)
+static unsigned long displayControlAdjust_SM750LE(
+		struct mode_parameter *pModeParam, unsigned long dispControl)
Ick, actually the original code is just fine here, please leave it
as-is.

thanks,,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help