[PATCH] media: omap2: omapfb: fix boolreturn.cocci warnings

STALE2929d

2 messages, 2 authors, 2018-07-31 · open the first message on its own page

[PATCH] media: omap2: omapfb: fix boolreturn.cocci warnings

From: kbuild test robot <hidden>
Date: 2018-07-25 17:57:35

From: kbuild test robot <redacted>

drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of 0/1 in function 'cmp_var_to_colormode' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST")
Signed-off-by: kbuild test robot <redacted>
---

 omapfb-main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
@@ -287,7 +287,7 @@ static bool cmp_var_to_colormode(struct
 			var->red.length = 0 ||
 			var->blue.length = 0 ||
 			var->green.length = 0)
-		return 0;
+		return false;
 
 	return var->bits_per_pixel = color->bits_per_pixel &&
 		cmp_component(&var->red, &color->red) &&

Re: [PATCH] media: omap2: omapfb: fix boolreturn.cocci warnings

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2018-07-31 11:04:03

On Thursday, July 26, 2018 01:57:00 AM kbuild test robot wrote:
From: kbuild test robot <redacted>

drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of 0/1 in function 'cmp_var_to_colormode' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST")
Signed-off-by: kbuild test robot <redacted>
Patch queued for 4.19 (w/ "media"->"fbdev" fixup in the patch title), thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help