Re: [PATCH v3] backlight: pwm_bl: Fix uninitialized variable
From: Lee Jones <hidden>
Date: 2018-07-25 05:22:18
Also in:
dri-devel, linux-pwm, lkml
From: Lee Jones <hidden>
Date: 2018-07-25 05:22:18
Also in:
dri-devel, linux-pwm, lkml
On Tue, 24 Jul 2018, Daniel Thompson wrote:
Currently, if the DT does not define num-interpolated-steps then
num_steps is undefined and the interpolation code will deploy randomly.
Fix with a simple initialize to zero.
Fixes: 573fe6d1c25c ("backlight: pwm_bl: Linear interpolation between
brightness-levels")
Reported-by: Marcel Ziswiler <redacted>
Signed-off-by: Daniel Thompson <redacted>
Tested-by: Marcel Ziswiler <redacted>
---
Notes:
v3:
- Switch to the simplest fix and zero the uninitialized variable. git
grep indicates that ~25% of calls to of_property_read_u32() use this
pattern (pre-initialize optional properties with sane values and
ignore the return code).
v2:
- Simplify SoB chain (with Marcel's permission)
- Separate complex if statement and make other similar calls use same
return code checking approach
- Tidy up comment formatting and fix pre-existing grammar error
drivers/video/backlight/pwm_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)Once the 'Fixes:' line has been repaired: Acked-by: Lee Jones [off-list ref] -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog