Thread (3 messages) 3 messages, 3 authors, 2018-07-24

Re: [PATCH] omapfb: rename omap2 module to omap2fb.ko

flat view

From: Tony Lindgren <tony@atomide.com>
Date: 2018-07-09 07:02:26
Also in: dri-devel, linux-omap, lkml

* Arnd Bergmann [off-list ref] [180706 12:39]:
In a kernel configuration with both CONFIG_FB_OMAP=m and CONFIG_FB_OMAP2=m,
Kbuild fails to point out that we have two modules with the same name (omapfb.ko),
but instead fails with a cryptic error message like:

ERROR: "omapfb_register_panel" [drivers/video/fbdev/omap/lcd_osk.ko] undefined!

This can now happen when building a randconfig kernel with CONFIG_ARCH_OMAP1,
as the omap1 fbdev driver depends on that, whiel the omap2 fbdev driver can
now be built anywhere with CONFIG_COMPILE_TEST.

The solution is to rename one of the two modules, so for consistency with
the directory naming I decided to rename the omap2 version to omap2fb.ko.
Sounds good to me:

Acked-by: Tony Lindgren <tony@atomide.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help