[PATCH] video: fbdev: simplefb: Stop including <linux/clk-provider.h>

Subsystems: framebuffer layer, simplefb fb driver, the rest

STALE2962d

4 messages, 4 authors, 2018-07-03 · open the first message on its own page

[PATCH] video: fbdev: simplefb: Stop including <linux/clk-provider.h>

From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: 2018-06-19 17:22:25

Simplefb is not a clock provider, but it uses of_clk_get_parent_count(),
so it can just include <linux/of_clk.h> instead.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/video/fbdev/simplefb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
index a3c44ecf4523e8ed..9a9d748b07f2777d 100644
--- a/drivers/video/fbdev/simplefb.c
+++ b/drivers/video/fbdev/simplefb.c
@@ -27,8 +27,8 @@
 #include <linux/platform_data/simplefb.h>
 #include <linux/platform_device.h>
 #include <linux/clk.h>
-#include <linux/clk-provider.h>
 #include <linux/of.h>
+#include <linux/of_clk.h>
 #include <linux/of_platform.h>
 #include <linux/parser.h>
 #include <linux/regulator/consumer.h>
-- 
2.17.1

Re: [PATCH] video: fbdev: simplefb: Stop including <linux/clk-provider.h>

From: Hans de Goede <hidden>
Date: 2018-06-19 17:30:53

Hi,

On 19-06-18 19:22, Geert Uytterhoeven wrote:
Simplefb is not a clock provider, but it uses of_clk_get_parent_count(),
so it can just include <linux/of_clk.h> instead.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
LGTM:

Acked-by: Hans de Goede <redacted>

Regards,

Hans


quoted hunk
---
  drivers/video/fbdev/simplefb.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
index a3c44ecf4523e8ed..9a9d748b07f2777d 100644
--- a/drivers/video/fbdev/simplefb.c
+++ b/drivers/video/fbdev/simplefb.c
@@ -27,8 +27,8 @@
  #include <linux/platform_data/simplefb.h>
  #include <linux/platform_device.h>
  #include <linux/clk.h>
-#include <linux/clk-provider.h>
  #include <linux/of.h>
+#include <linux/of_clk.h>
  #include <linux/of_platform.h>
  #include <linux/parser.h>
  #include <linux/regulator/consumer.h>

Re: [PATCH] video: fbdev: simplefb: Stop including <linux/clk-provider.h>

From: Stephen Boyd <sboyd@kernel.org>
Date: 2018-06-19 20:12:32

Quoting Geert Uytterhoeven (2018-06-19 10:22:21)
Simplefb is not a clock provider, but it uses of_clk_get_parent_count(),
so it can just include <linux/of_clk.h> instead.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Acked-by: Stephen Boyd <sboyd@kernel.org>

Re: [PATCH] video: fbdev: simplefb: Stop including <linux/clk-provider.h>

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2018-07-03 15:10:40

On Tuesday, June 19, 2018 07:22:21 PM Geert Uytterhoeven wrote:
Simplefb is not a clock provider, but it uses of_clk_get_parent_count(),
so it can just include <linux/of_clk.h> instead.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch queued for 4.19, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help