Re: [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

Hi,

On 26-06-18 16:47, Steven Rostedt wrote:

On Tue, 26 Jun 2018 15:55:34 +0200
Hans de Goede [off-list ref] wrote:

quoted

Replace comments about places where the console lock should be held with
calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held.

Why replace the comments? I prefer them, even with the WARN. The reason
is, when using functions, I don't tend to look inside the function I'm
about to use, but instead, I expect the comment above the function to
have basic information I need to use it. Especially what locks are
expected to be held.

Please keep the comments in place, but the WARNs are fine. They are not
a replacement for the comments.

Nack on removing comments.

Ok, I will submit a v4 with the comments left in place.

Regards,

Hans