Re: [PATCH 5/6] mtd: rawnand: ams-delta: use GPIO lookup table
flat view
From: Andy Shevchenko <hidden>
Date: 2018-05-18 21:21:19
Also in:
alsa-devel, linux-arm-kernel, linux-input, linux-omap, lkml
On Sat, May 19, 2018 at 12:09 AM, Janusz Krzysztofik [off-list ref] wrote:
+ gpiod_rdy = devm_gpiod_get_optional(&pdev->dev, "rdy", GPIOD_IN);
+ if (!IS_ERR_OR_NULL(gpiod_rdy)) {So, is it optional or not at the end? If it is, why do we check for NULL?
this->dev_ready = ams_delta_nand_ready;
} else {
this->dev_ready = NULL;
pr_notice("Couldn't request gpio for Delta NAND ready.\n");dev_notice() ?
}
quoted hunk ↗ jump to hunk
+err_gpiod: + if (err = -ENODEV || err = -ENOENT) + err = -EPROBE_DEFER;
Hmm... -- With Best Regards, Andy Shevchenko