Re: [PATCH] Fix checkpatch warnings in goldfishfb.c
From: Roman Kiryanov <hidden>
Date: 2018-05-23 21:46:11
Hi, could you please confirm you received the patch? Regards, Roman. On Fri, May 18, 2018 at 4:32 PM [off-list ref] wrote:
From: Roman Kiryanov <redacted>
Signed-off-by: Roman Kiryanov <redacted> --- drivers/video/fbdev/goldfishfb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/fbdev/goldfishfb.c
b/drivers/video/fbdev/goldfishfb.c
quoted hunk ↗ jump to hunk
index 3b70044773b6..de29c4ff77e5 100644--- a/drivers/video/fbdev/goldfishfb.c +++ b/drivers/video/fbdev/goldfishfb.c@@ -124,6 +124,7 @@ static int goldfish_fb_check_var(struct
fb_var_screeninfo *var,
static int goldfish_fb_set_par(struct fb_info *info)
{
struct goldfish_fb *fb = container_of(info, struct goldfish_fb,fb);
quoted hunk ↗ jump to hunk
+ if (fb->rotation != fb->fb.var.rotate) { info->fix.line_length = info->var.xres * 2; fb->rotation = fb->fb.var.rotate;@@ -148,13 +149,14 @@ static int goldfish_fb_pan_display(struct
fb_var_screeninfo *var,
wait_event_timeout(fb->wait,
fb->base_update_count != base_update_count, HZ /15);
if (fb->base_update_count = base_update_count)
- pr_err("goldfish_fb_pan_display: timeout waiting for baseupdate\n");
+ pr_err("%s: timeout waiting for base update\n", __func__);
return 0;
} static int goldfish_fb_blank(int blank, struct fb_info *info)
{
struct goldfish_fb *fb = container_of(info, struct goldfish_fb,fb);
+
switch (blank) {
case FB_BLANK_NORMAL:
writel(1, fb->reg_base + FB_SET_BLANK);
--
2.17.0.441.gb46fe60e1d-goog