Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
From: Lee Jones <hidden>
Date: 2018-04-24 10:07:30
Also in:
dri-devel, linux-pwm, linux-renesas-soc, lkml
From: Lee Jones <hidden>
Date: 2018-04-24 10:07:30
Also in:
dri-devel, linux-pwm, linux-renesas-soc, lkml
On Tue, 24 Apr 2018, Geert Uytterhoeven wrote:
On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman [off-list ref] wrote:quoted
On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote:quoted
On Wed, 11 Apr 2018, Simon Horman wrote:quoted
On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:quoted
The documentation was wrong, gpiod_get_direction() returns 0/1 instead of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47 ("gpio: correct docs about return value of gpiod_get_direction"). Now, fix this user (until a better, system-wide solution is in place). Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by: Daniel Thompson <redacted>Reviewed-by: Simon Horman <redacted>Thanks for the Reviewed-by Simon. I have applied it to the original mail. Do you know why you mail wasn't sent attached to the original thread? For some reason I received this mail on it's own i.e. not in reply to the original.No, not off hand. Perhaps I responded to the email in some unusual way but by now I don't recall. In any case I'll try to be more careful in future.I see Lee is using gmail for sending, so I assume also for receiving.
Well I'm using their servers, but my set-up is IMAP/Mutt.
While I did receive Simon's reply in-thread, lately I had issues with gmail not always doing so, and sometimes failing to do deduplication when receiving email through multiple paths (mailing lists and/or directly).
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog