Thread (16 messages) 16 messages, 2 authors, 2018-03-28

Re: [PATCH v3 1/3] video: smscufx: Less checks in ufx_usb_probe() after error detection

flat view

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2018-03-28 13:46:41
Also in: dri-devel, kernel-janitors, lkml

On Sunday, January 07, 2018 05:02:21 PM SF Markus Elfring wrote:
From: Markus Elfring <redacted>
Date: Sun, 7 Jan 2018 15:56:11 +0100

Up to four checks could be repeated by the ufx_usb_probe() function
during error handling even if the relevant properties can be determined
for the involved variables before by source code analysis.

* Return directly after a call of the function "kzalloc" failed
  at the beginning.

* Adjust jump targets so that extra checks can be omitted at the end.

* Delete initialisations for the variables "info" and "retval"
  which became unnecessary with this refactoring.

Signed-off-by: Markus Elfring <redacted>
Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help