Re: [PATCH v5 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle.
From: Lee Jones <hidden>
Date: 2018-02-01 12:06:53
Also in:
linux-pwm, linux-rockchip, lkml
On Tue, 30 Jan 2018, Enric Balletbo Serra wrote:
Hi, 2017-12-01 13:06 GMT+01:00 Enric Balletbo i Serra [off-list ref]:quoted
Before this patch the enable signal was set before the PWM signal and vice-versa on power off. This sequence is wrong, at least, it is on the different panels datasheets that I checked, so I inverted the sequence to follow the specs. For reference the following panels have the mentioned sequence: - N133HSE-EA1 (Innolux) - N116BGE (Innolux) - N156BGE-L21 (Innolux) - B101EAN0 (Auo) - B101AW03 (Auo) - LTN101NT05 (Samsung) - CLAA101WA01A (Chunghwa) Signed-off-by: Enric Balletbo i Serra <redacted> Acked-by: Daniel Thompson <redacted> Acked-by: Jingoo Han <jingoohan1@gmail.com> --- Changes since v4: - Rebase on top of mainline. - Add the acks from Daniel Thompson and Jingoo Han. Changes since v3: - List the part numbers for the panel checked (Daniel Thompson) Changes since v2: - Add this as a separate patch (Thierry Reding) Changes since v1: - None drivers/video/backlight/pwm_bl.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)A gentle ping, It's been nearly two months since I sent this patchset, there is anything else that prevents these patches to land or incorporate in linux-next?
Looks like Daniel should Ack 2/5 since he had comments on it before and it still lacks a Backlight Ack. With regards to -next, the merge-window is open (should close in a little over a week), so the chances are, you'll get a long soak before the next merge-window opens. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog