Re: [PATCH 3/5] backlight: lm3639: document sysfs attributes
From: Daniel Thompson <hidden>
Date: 2018-01-31 11:34:23
Also in:
dri-devel, lkml
On Fri, Jan 26, 2018 at 08:23:57PM +0530, Aishwarya Pant wrote:
quoted hunk ↗ jump to hunk
Add documentation for sysfs interfaces of Texas Instruments lm3639 backlight + flash led driver chip by looking through git commits and reading code. Signed-off-by: Aishwarya Pant <redacted> --- Documentation/ABI/testing/sysfs-class-backlight-lm3639 | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-backlight-lm3639diff --git a/Documentation/ABI/testing/sysfs-class-backlight-lm3639 b/Documentation/ABI/testing/sysfs-class-backlight-lm3639 new file mode 100644 index 000000000000..ec87dc8f4395 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-class-backlight-lm3639@@ -0,0 +1,13 @@ +sysfs interface for Texas Instruments lm3639 backlight + flash led driver chip +------------------------------------------------------------------------------ + +What: /sys/class/backlight/<backlight>/bled_mode +Date: Oct, 2012 +KernelVersion: v3.10 +Contact: Lee Jones <lee.jones@linaro.org>, + Daniel Thompson <daniel.thompson@linaro.org>, + Jingoo Han <jingoohan1@gmail.com>
We've recently added a ML to MAINTAINERS (see https://patchwork.kernel.org/patch/10169327/ ). I think a better Contact might simply be: Contact: dri-devel@lists.freedesktop.org
+Description: + (WO) Write to the backlight mapping mode. The backlight current + can be mapped for either exponential (value "0") or linear + mapping modes (default).
The ambiguity of meaning w.r.t. linear or exponential is something of a thorn in the side of backlight... and so long as that ambiguity remains this control is something the userspace may want to poke (albeit only once during boot). If you repost with an updated contact then please add my ack for this patch: Acked-by: Daniel Thompson <redacted> Daniel.