Re: [PATCH v2 0/5] video: udlfb: (not only) Logging cleanup
From: Ladislav Michl <hidden>
Date: 2018-01-15 15:30:19
Bartlomiej, On Mon, Jan 15, 2018 at 03:28:35PM +0100, Bartlomiej Zolnierkiewicz wrote:
I queued patches #1-4 for v4.16, thanks.quoted
quoted
video: udlfb: Switch from the pr_*() to the dev_*() logging functionsThis one introduces new compile time warning: drivers/video/fbdev/udlfb.c: In function ‘dlfb_init_framebuffer_work’: drivers/video/fbdev/udlfb.c:1694:24: warning: ignoring return value of ‘device_create_bin_file’, declared with attribute warn_unused_result [-Wunused-result] device_create_bin_file(info->dev, &edid_attr); ^ Checking of device_create_bin_file()'s return value should not be removed, [ ditto for device_create_file() ] Also please fix the new comment introduced by the patch: + /* parent device is used otherwise*/ [ ...e*/ -> ...e */ ]
Fixed those and few more checkpatch warnings and will send v3 of just this patch. However I'd like to know what toolchain are you using as I didn't see above warning. Thank you, ladis