Re: [PATCH v3 27/27] devres: kill devm_ioremap_nocache
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2017-12-23 13:45:41
Also in:
alsa-devel, dmaengine, dri-devel, linux-can, linux-gpio, linux-ide, linux-media, linux-mips, linux-mmc, linux-pci, linux-rtc, linux-spi, linux-watchdog, linux-wireless, lkml, netdev, platform-driver-x86
On Sat, Dec 23, 2017 at 07:02:59PM +0800, Yisheng Xie wrote:
quoted hunk ↗ jump to hunk
--- a/lib/devres.c +++ b/lib/devres.c@@ -44,35 +44,6 @@ void __iomem *devm_ioremap(struct device *dev, resource_size_t offset, EXPORT_SYMBOL(devm_ioremap); /** - * devm_ioremap_nocache - Managed ioremap_nocache() - * @dev: Generic device to remap IO address for - * @offset: Resource address to map - * @size: Size of map - * - * Managed ioremap_nocache(). Map is automatically unmapped on driver - * detach. - */ -void __iomem *devm_ioremap_nocache(struct device *dev, resource_size_t offset, - resource_size_t size) -{ - void __iomem **ptr, *addr; - - ptr = devres_alloc(devm_ioremap_release, sizeof(*ptr), GFP_KERNEL); - if (!ptr) - return NULL; - - addr = ioremap_nocache(offset, size);
Wait, devm_ioremap() calls ioremap(), not ioremap_nocache(), are you _SURE_ that these are all identical? For all arches? If so, then ioremap_nocache() can also be removed, right? In my quick glance, I don't think you can do this series at all :( greg k-h