[PATCH] video/console/sticore: Delete an error message for a failed memory allocation in sti_try_rom_generic()

Subsystems: console subsystem, framebuffer layer, parisc architecture, the rest

STALE3107d

2 messages, 2 authors, 2018-03-28 · open the first message on its own page

[PATCH] video/console/sticore: Delete an error message for a failed memory allocation in sti_try_rom_generic()

From: SF Markus Elfring <hidden>
Date: 2017-12-05 18:00:39

From: Markus Elfring <redacted>
Date: Tue, 5 Dec 2017 18:45:42 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/video/console/sticore.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/console/sticore.c b/drivers/video/console/sticore.c
index d1d3796773aa..08b822656846 100644
--- a/drivers/video/console/sticore.c
+++ b/drivers/video/console/sticore.c
@@ -827,10 +827,8 @@ static struct sti_struct *sti_try_rom_generic(unsigned long address,
 	}
 	
 	sti = kzalloc(sizeof(*sti), GFP_KERNEL);
-	if (!sti) {
-		printk(KERN_ERR "Not enough memory !\n");
+	if (!sti)
 		return NULL;
-	}
 
 	spin_lock_init(&sti->lock);
 
-- 
2.15.1

Re: [PATCH] video/console/sticore: Delete an error message for a failed memory allocation in sti_try_rom_generic()

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2018-03-28 14:19:46

On Tuesday, December 05, 2017 07:00:22 PM SF Markus Elfring wrote:
From: Markus Elfring <redacted>
Date: Tue, 5 Dec 2017 18:45:42 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help