[PATCH v4 0/2] Fixes for omapdrm on OpenPandora and GTA04

STALE3180d

Revision v4 of 4 in this series.

6 messages, 3 authors, 2017-12-19 · open the first message on its own page

[PATCH v4 0/2] Fixes for omapdrm on OpenPandora and GTA04

From: H. Nikolaus Schaller <hidden>
Date: 2017-12-01 07:42:00

Changes V4:
* removed already accepted panel driver patches
* reworded commit subject to clarify

2017-11-28 16:49:00: Changes V3:
* stay compatible with old DTB files which still use "toppoly" (suggested by Tomi Valkeinen)
* replaced MODULE_ALIAS entries by MODULE_DEVICE_TABLE (suggested by Andrew F. Davis)
* removed DSI VDDS patch as it has already been accepted

2017-11-16 09:50:22: Changes V2:
* replaced patch to fix DSI VDDS for OMAP3 by equivalent patch from Laurent Pinchart
* keep previous compatibility option in panel driver to handle older device tree binaries

2017-11-08 22:09:36:
This patch set fixes vendor names of the panels
and fixes a problem on omapdrm with enabling
VDD_DSI for OMAP3 which is needed for displaying
the Red and Green channel on OMAP3530 (Pandora).

H. Nikolaus Schaller (2):
  DTS: GTA04: improve panel compatibility string
  DTS: Pandora: fix panel compatibility string

 arch/arm/boot/dts/omap3-gta04.dtsi          | 2 +-
 arch/arm/boot/dts/omap3-pandora-common.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.12.2

[PATCH v4 2/2] DTS: Pandora: fix panel compatibility string

From: H. Nikolaus Schaller <hidden>
Date: 2017-12-01 07:42:03

We can remove the unnecessary "omapdss," prefix because
the omapdrm driver takes care of it when matching with
the driver table.

Signed-off-by: H. Nikolaus Schaller <redacted>
---
 arch/arm/boot/dts/omap3-pandora-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap3-pandora-common.dtsi b/arch/arm/boot/dts/omap3-pandora-common.dtsi
index 53e007abdc71..64d967ec8c58 100644
--- a/arch/arm/boot/dts/omap3-pandora-common.dtsi
+++ b/arch/arm/boot/dts/omap3-pandora-common.dtsi
@@ -626,7 +626,7 @@
 
 	lcd: lcd@1 {
 		reg = <1>;	/* CS1 */
-		compatible =	"omapdss,tpo,td043mtea1";
+		compatible =	"tpo,td043mtea1";
 		spi-max-frequency = <100000>;
 		spi-cpol;
 		spi-cpha;
-- 
2.12.2

[PATCH v4 1/2] DTS: GTA04: improve panel compatibility string

From: H. Nikolaus Schaller <hidden>
Date: 2017-12-01 07:42:43

Official vendor string is now "tpo" and not "toppoly".

Requires patch "omapdrm: panel: fix compatible vendor string for td028ttec1"
so that the driver understands both.

Signed-off-by: H. Nikolaus Schaller <redacted>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 4504908c23fe..ec27ed67a22a 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -86,7 +86,7 @@
 
 		/* lcd panel */
 		lcd: td028ttec1@0 {
-			compatible = "toppoly,td028ttec1";
+			compatible = "tpo,td028ttec1";
 			reg = <0>;
 			spi-max-frequency = <100000>;
 			spi-cpol;
-- 
2.12.2

Re: [PATCH v4 1/2] DTS: GTA04: improve panel compatibility string

From: Tony Lindgren <tony@atomide.com>
Date: 2017-12-11 15:22:11

* H. Nikolaus Schaller [off-list ref] [171201 07:44]:
Official vendor string is now "tpo" and not "toppoly".

Requires patch "omapdrm: panel: fix compatible vendor string for td028ttec1"
so that the driver understands both.
Tomi, so what's the plan with the dependency patch, is that for v4.16
or for the v4.15-rc cycle?

Regards,

Tony


quoted hunk
Signed-off-by: H. Nikolaus Schaller <redacted>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 4504908c23fe..ec27ed67a22a 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -86,7 +86,7 @@
 
 		/* lcd panel */
 		lcd: td028ttec1@0 {
-			compatible = "toppoly,td028ttec1";
+			compatible = "tpo,td028ttec1";
 			reg = <0>;
 			spi-max-frequency = <100000>;
 			spi-cpol;
-- 
2.12.2

Re: [PATCH v4 1/2] DTS: GTA04: improve panel compatibility string

From: Tomi Valkeinen <hidden>
Date: 2017-12-19 10:50:31

On 11/12/17 17:22, Tony Lindgren wrote:
* H. Nikolaus Schaller [off-list ref] [171201 07:44]:
quoted
Official vendor string is now "tpo" and not "toppoly".

Requires patch "omapdrm: panel: fix compatible vendor string for td028ttec1"
so that the driver understands both.
Tomi, so what's the plan with the dependency patch, is that for v4.16
or for the v4.15-rc cycle?
The dependency patch for this one is queued for v4.16 (I just sent a 
pull request today). I could pick this one up (if you give an ack) if I 
send another DRM pull request, but I probably don't have anything else 
to send so most likely I won't pick this up for v4.16.

The patch 2/2 in the series doesn't have dependencies and can be applied 
as a fix for 4.15, or for 4.16.

Neither of these are critical, as things work fine without these patches.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. 
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: [PATCH v4 1/2] DTS: GTA04: improve panel compatibility string

From: Tony Lindgren <tony@atomide.com>
Date: 2017-12-19 14:37:43

* Tomi Valkeinen [off-list ref] [171219 10:51]:
On 11/12/17 17:22, Tony Lindgren wrote:
quoted
* H. Nikolaus Schaller [off-list ref] [171201 07:44]:
quoted
Official vendor string is now "tpo" and not "toppoly".

Requires patch "omapdrm: panel: fix compatible vendor string for td028ttec1"
so that the driver understands both.
Tomi, so what's the plan with the dependency patch, is that for v4.16
or for the v4.15-rc cycle?
The dependency patch for this one is queued for v4.16 (I just sent a pull
request today). I could pick this one up (if you give an ack) if I send
another DRM pull request, but I probably don't have anything else to send so
most likely I won't pick this up for v4.16.
OK thanks I'll queue both of these for v4.16 then.
The patch 2/2 in the series doesn't have dependencies and can be applied as
a fix for 4.15, or for 4.16.

Neither of these are critical, as things work fine without these patches.
OK thanks for confirming that.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help