Thread (22 messages) 22 messages, 4 authors, 2017-11-28

Re: [PATCH v2 2/4] DTS: GTA04: fix panel compatibility string

From: H. Nikolaus Schaller <hidden>
Date: 2017-11-28 16:05:24
Also in: dri-devel, linux-arm-kernel, linux-devicetree, linux-omap, lkml

Am 28.11.2017 um 17:00 schrieb Tony Lindgren [off-list ref]:

* H. Nikolaus Schaller [off-list ref] [171128 15:51]:
quoted
quoted
Am 28.11.2017 um 16:10 schrieb Tony Lindgren [off-list ref]:
OK fine dropping both. Please update the description in both dts
patches to make it clear they are needed as a fix. Preferrably
with a proper fixes tag.
Well, it is not "needed" in a strong sense since current mainline&stable
works. It is more a style and consistency fix to use "tpo," everywhere.
quoted
Having "We can remove the "omapdss," prefix" in the description sure
does not sounds like it's needed as a fix :)
The description has been improved on -v3.
Thanks.
quoted
quoted
Sounds like maybe these two should be just a single patch for
a proper fix?
Hm. I usually get the feedback to separate DT and driver fixes into
separate commits... Therefore I submit patch sets in the hope they
are not picked apart :)
See "both dts patches" part above. Yes the dts patches can and should
be sent separately. In almost every case if the dts patches cannot be
applied separately it means your driver changes are breaking things.
That is why the v3 driver now accepts both, the old and the new vendor
name. This means applying the driver alone is safe. Applying or not
applying DTS patch afterwards is also safe.

BR,
Nikolaus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help