On Sat, Nov 25, 2017 at 05:48:11PM -0500, Jeremy Lacomis wrote:
quoted hunk ↗ jump to hunk
This is a patch to sm750_accel.c that fixes 80-character line length
warnings found by checkpatch.pl. It also fixes some grammatical errors
in comments and moves parameter-specific comments from inline to before
the function.
Signed-off-by: Jeremy Lacomis <redacted>
---
Changes in v2:
- Change function comments to the kernel-doc format
drivers/staging/sm750fb/sm750_accel.c | 189 ++++++++++++++++++----------------
1 file changed, 103 insertions(+), 86 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 1035e91e7cd3..42cd920111bf 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
Why did you change this line? That is not correct.
Only ever do one "logical" thing per patch. If you have to say "also"
in a changelog text, that's a huge hint you are doing something wrong.
thanks,
greg k-h