Re: [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot()

On Mon, 27 Nov 2017, Jingoo Han wrote:

On Monday, November 27, 2017 11:58 AM, Sinan Kaya wrote:

quoted

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
where a PCI device is present. This restricts the device drivers to be
reused for other domain numbers.

I think that this will be useful. I introduced multi domains into
ARM-based PCIe driver. (e.g. domain 0, and domain 1) So, APIs to choose
domain will be used later.

quoted

Getting ready to remove pci_get_bus_and_slot() function in favor of
pci_get_domain_bus_and_slot().

Hard-coding the domain as 0.

Acked-by: Daniel Thompson <redacted>
Signed-off-by: Sinan Kaya <redacted>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

I can't apply this.

It looks like I was missing from the list of addressees.

Please resend v3 with all the Acks you've acquired.

quoted

---
 drivers/video/backlight/apple_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/apple_bl.c

b/drivers/video/backlight/apple_bl.c
index d843296..6a34ab9 100644

--- a/drivers/video/backlight/apple_bl.c
+++ b/drivers/video/backlight/apple_bl.c

@@ -143,7 +143,7 @@ static int apple_bl_add(struct acpi_device *dev)
 	struct pci_dev *host;
 	int intensity;

-	host = pci_get_bus_and_slot(0, 0);
+	host = pci_get_domain_bus_and_slot(0, 0, 0);

 	if (!host) {
 		pr_err("unable to find PCI host\n");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog